feat: allow multiple root spans to exist in a tracetest trace #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is related to the issue #2517 |
mathnogueira
changed the title
mathnogueira
changed the title
schoren
reviewed
May 10, 2023
| @@ -23,23 +23,30 @@ func NewTrace(traceID string, spans []Span) Trace { | |||
| spanMap[spanID] = &spanCopy | |||
| } | |||
|
|
|||
| var rootSpan *Span = nil | |||
| rootSpans := make([]*Span, 0) | |||
There was a problem hiding this comment.
Would it make sense to preallocate the space?
Suggested change
| rootSpans := make([]*Span, 0) | |
| rootSpans := make([]*Span, 0, len(spanMap)) |
There was a problem hiding this comment.
I don't think it's worth it because most traces have only one root span. This would allocate way too much space in most cases.
danielbdias
approved these changes
May 10, 2023
schoren
pushed a commit
that referenced
this pull request
Jun 5, 2023
allow multiple roots to exist in a tracetest test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows our traces to have multiple root spans. They will always be children of the trigger span
Checklist